More Awesome Than You!

TS2: Burnination => Oops! You Broke It! => Topic started by: Final Warrior on 2006 June 30, 02:10:32



Title: Conflict between Bring Friend(NL) Home and NoFraternization?
Post by: Final Warrior on 2006 June 30, 02:10:32
Straight from Paladin's Place Hack Conflict Detection Utility"

Quote
Report Start 6/29/2006 6:58:07 PM
 
*** POSSIBLE CONFLICT DETECTED ***
Procedure Name: Sub - Get in T[0] - School Friend
Group ID: 0x7FBE051B
Instance ID: 0x00002029
Packages Containing This Procedure:
\downloads\Awesome hacks\NL - school bus - bring friend dialog.package
\downloads\Awesome hacks\nofraternization.package
 
End Of Report
 
1 possible conflicts detected.

As i can't find what NoFrat does... can anyone explain NoFrat unto me?

-- Griffinhart


Title: Re: Conflict between Bring Friend(NL) Home and NoFraternization?
Post by: cwieberdink on 2006 June 30, 02:30:24
I believe NoFrat means if there is something queued for your sim when s/he leaves for work, they will not bring a friend home because "they already have plans" after work.

C


Title: Re: Conflict between Bring Friend(NL) Home and NoFraternization?
Post by: gjam on 2006 June 30, 02:45:54
According to the Hack Descriptions Thread (http://www.moreawesomethanyou.com/smf/index.php?topic=2086.0), nofraternization is:
     "Sims will only bring co-workers home from the same job level that they are currently on."


Title: Re: Conflict between Bring Friend(NL) Home and NoFraternization?
Post by: RainbowTigress on 2006 June 30, 02:55:00
Ah, gjam beat me to it.  I will add, however, that this conflict has been discussed also in TwoJeff's forum in the thread for his School Bus & Bring Friend Home Dialogs (http://www.moreawesomethanyou.com/smf/index.php?topic=1239.msg113131#msg113131) hack.


Title: Re: Conflict between Bring Friend(NL) Home and NoFraternization?
Post by: Final Warrior on 2006 June 30, 03:09:23
Hehe. i feel stupid.

Well, guess NoFrat goes bye-bye...

-- Griffinhart


Title: Re: Conflict between Bring Friend(NL) Home and NoFraternization?
Post by: RainbowTigress on 2006 June 30, 04:03:15
That was my choice as well.


Title: Re: Conflict between Bring Friend(NL) Home and NoFraternization?
Post by: BlueSoup on 2006 June 30, 04:06:52
Well, my Sims never bring home friends (I haven't seen it in forever) and I still get the dialogue.  I haven't done anything to get that though.  ???


Title: Re: Conflict between Bring Friend(NL) Home and NoFraternization?
Post by: RainbowTigress on 2006 June 30, 04:10:34
Theoretically, if TJ's hack loads after Pescado's, then TJ's code should be what the game uses.  I was noticing that things weren't quite working as they used to, and after reading that thread, I finally concluded it was a conflict and removed JM's hack. 


Title: Re: Conflict between Bring Friend(NL) Home and NoFraternization?
Post by: syberspunk on 2006 June 30, 10:34:33
I did make a version that combines the two. I looked at the code from nofrat, and it does a few of things:

1) It does check the interaction queue, so I think cwieberdink is correct about that.

2) For adults and teens, it also checks whether the sim they are trying to bring home is within 2 levels/ranks up or down of the sim's current promotion level/rank with respect to jobs.

3) For children and teens, it also checks whether the sim they are trying to bring home is in the same school type (private vs. public).

This 3rd point is pretty much the only thing conflicting with twojeffs' school bus dialog hack. If you want to keep the rest of nofrat and still have the functionality of the school bus dialog hack, you have two options:

1) Ensure that twojeffs' hack loads last (by whatever method you prefer). Or

2) Delete the BHAV Group 0x7F8F4EB6 Instance 0x202D.

If you want the school bus hack with Pescado's changes included (the part that makes sure children and teens only bring home other kids from their school type) you can use the merged version I posted in twojeffs' thread. I included the queue check and the school type check.

I've also been toying with a similar hack for bringing home co-workers. I know Monique posted a hack on MTS2 for this, but I wasn't satisfied with how it worked. Besides, I had been toying with it before she actually posted it, and then put it on the backburner when I found out she made one. Anyhew... I pretty much modeled it after twojeffs' hack, keeping the same options (yes, no, and cancel) as well as the random criteria/preference for choosing sims (whether they met yet, if they were playable or townies, etc.). It also includes nofrat changes because it would otherwise conflict in a similar way that twojeffs' school bus dialog hack conflicts. I'll probably playtest it for a bit, and if anyone is actually interested, I'll gladly make it available. :)

Ste


Title: Re: Conflict between Bring Friend(NL) Home and NoFraternization?
Post by: cwieberdink on 2006 June 30, 11:52:34
I did make a version that combines the two. I looked at the code from nofrat, and it does a few of things:

1) It does check the interaction queue, so I think cwieberdink is correct about that.


Thanks, Ste, I was too lazy to go RTFM on the hack, but that is what JM was saying in chat once when I was asking why my sims didn't bring friends home from work anymore.  He mentioned NoFrat and said if they "already had plans" they wouldn't bring someone home.  I removed it also.

C