More Awesome Than You!

We are proud to present, the most wonderfull, fully tested, completely bug free.....

...complete pile of crap that is the sims 2.

Sims should now have aspiration decay normally and be able to use aspirational objects correctly.

This doesn't actually fix anything, so there may be other problems with aspirations due to the fact that the secondary aspiration is not set correctly in the token.

*** Withdrawn***

Welcome back mate.  8)

He lives!

And bears gifts!

He returns with the best fix bypass ever! Thank you, Crammyboy!  :-*

Weirdness. Why does bypassing the test for bit 4 (unused aspiration) being set somehow fix this? That looked like an entirely legal test to me, unless EAxis reused that bit to indicate something else. Does something actually set that bit? And how does it cause aspirational rewards to apparently fail in silence, as I tried stubbing out all the False returns to the Aspirational Reward Failure test, making it impossible to fail without error-resetting, yet somehow testers reported this continued?

Geez, Pescado.  Not even a "Where the hell have you been?"

Apparently the bit is set in the token used to indicate which of the bits in the aspiration is the secondary one. Who sets this bit or why is unkown at present, but with the bit being returned as the primary aspiration (clearly untrue) and no other code using it, aspiration actions are all bypassed.

That explains why the one sim I had who didn't fail his aspiration tests was one that didn't have an secondary aspiration assigned.

Yay! Crammyboy is alive! :D

Hey Crammyboy, curious, does this do the same thing or conflict with Twojeff's fix (http://box156.bluehost.com/~aestudi1/forums/inteenimater/viewtopic.php?f=32&t=19)?


Ste

The problem with the aspiration borkeness is that 0x611 (get secondary asp) returns the VALUE of the flag, not the flag field. EAxis then tries to XOR this value in 0x403, which of course returns absolute crap because what was returned was not a flag field. My fix corrects this.

TwoJeffs, since you're here, does your fix correct the aspirations getting stuck in perma plat when they shouldn't be?

I think that's unrelated (although I haven't played enough to know for sure). Permaplat is indicated in a completely different sim flag field from the aspiration, unless EAxis moved it in FT.

It is entirely possible though that the game returning completely bogus aspriation info was blowing up some other code and my fix will correct all kinds of problems. It will fix bogus red marriage memories for non-romance sims among other things for sure.

ETA: On further review, I do think my fix will correct that (and the asp reward problems) too. The Aspiration - Get Level calls the 'Get aspiration' code that I fixed, so the bogus aspiration info was causing a bogus aspiration level to be returned.

Jeffies code does what it says on the tin.

Case closed.